The main problem with current W10M situation is the software so I don't agree with people waiting Surface Phone to be a savior. It might have a few cool features over 950 but it will have the same software.
Currently, W10 (especially Mobile) is a mess. Lots of software are from WP8 era and work slow compared to apps specifically written for W10 (for example, 6tag or WhatsApp). New cool features I was waiting (like PC <-> Phone sync) are announced to be Cortana dependent which is not available in my country, so I won't be able to benefit from them. This made me disappointed for the second time recently after the announcement of older Lumias not getting W10M.
W10 was so buggy when it first came out with 950/XL that it has only recently reached a stability point after phones are already 5 months old.
The announcement that phones with only 2.5 year old hardware won't support W10M made people question how much value Microsoft gives to its customers. A lot of people were already skeptic because of WP7 -> WP8 transition and they turned out to be right. If I buy a Lumia 950 will it get the latest and greatest version of W10M after 3 years? Nobody can guarantee anymore.
If you are going to still buy WP under these conditions then you really need to be a fan of WP or maybe have a very specific reason which makes you not switch. I used to recommend WP to my friends until 2 years ago but right now I can't since they will definitely get more value by getting an iPhone SE for example. I still consider giving MS one more chance but there are so many things that makes this decision very hard...
I started out being a WP fan in 2012 but now have lost any desire per se for some of the exact reasons you state, the wait has been much too long with the stories constantly changing, mostly not for the betterment of the platform IMO.
While the other platforms are producing products/software in the mobile industry that advance and entices the consumer MS keeps living in a fantasy world, some day it may come to fruition but it is that day that leaves most wondering, 1-2 years down the road, longer or never.
It’s one thing to have faulty, buggy or a bad batch of devices but an Inconsistent OS is another thing, still reading way too many situations where W10M is having issues running on same/similar devices, one person will proclaim “mine runs flawlessly” but the next “slow, glitchy, battery eater”, all on same devices. The elusive “hard reset” is downright dismal in this day and age, what, spend hours or days tweaking in hopes that you’ll end up with a satisfactory running device not to mention one may have to go through this process umpteen times, that’s 90s crap… Don’t disagree it is the best recourse yet the percentages as “the need to” tell me something is amiss.
WP will probably never die but IMO it is going to be a very long road before is flourishes if it ever does, past history has shown many restarts and to-date what has changed in that respect?
Because I am familiar with WP in general and “there are” a few preferences and niceties that it does offer/is better at, we'll continue to use our Ativ S/L1020/L830, slowly though we are gradually getting bored with them as they appear to be advancing into the dark ages quickly or are there already, looking back from day 1 I'm hard-pressed to see the advancements that should have been.
Starting in the beginning of 2015 and moving forward nothing that MS has done got my adrenaline flowing, each and every so-called progression had a caveat of one form or another that just toned down my enthusiasm for the platform, when my present devices have run their course I don’t see myself looking back for quite some time, it’ll have to be a reasonable time of stability and progression before I even consider another WM device.