My Lumia 950 XL is my daily driver. I don't have any other phone. Granted, I'm much more of a business user, heavily steeped in Office 365, SharePoint, Teams, Exchange, etc. So, my needs are met pretty well. I only occasionally feel the app gap in a palpable way, where I just won't find a comparable app that I have on my Android tablet. But, even w/ my Android tablet, I'm not the kind of guy installing tons of apps, puttzing time away on them. And, honestly, the ever growing list of UWP apps, extended down to mobile, keep the app situation interesting-ish enough for me (for now).
I've seen benchmarks, where the current Alcatel and HP flagship windows phones don't deliver a whole lot of performance beyond what my 950XL already does (not to mention, their cameras fall short of the 950XL). So, I see myself holding onto my 950XL (which I've had for just under a year now) for another 1.5 to 2 years. That is, unless MS or an OEM does something amazing w/ Windows on Arm, that reasonably approaches a phone form factor, which also works w/ my wireless carrier.